fix: prevent extension from hanging when embedder service is unavailable #8779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made CodeIndexManager initialization non-blocking during extension activation - Added 5-second timeout to embedder validation to prevent indefinite hanging - Extension now loads successfully even if embedder service is missing Fixes #8777
dosubot
bot
added
size:M
Review SummaryI've reviewed the changes in this PR. The approach successfully makes CodeIndexManager initialization non-blocking and adds a timeout to prevent indefinite hanging when the embedder service is unavailable. However, I found one minor issue with type annotations: Issues to Address
|
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| // Add a timeout to prevent hanging when the embedder service is unavailable | ||
| const VALIDATION_TIMEOUT_MS = 5000 // 5 seconds timeout | ||
|
|
||
| const timeoutPromise = new Promise<{ valid: boolean; error: string }>((_, reject) => { |
There was a problem hiding this comment.
The timeout promise is typed as Promise<{ valid: boolean; error: string }> but only ever calls reject(), never resolve(). The type annotation is misleading since this promise will never successfully resolve to that type. Consider using Promise<never> or removing the type annotation entirely to let TypeScript infer it correctly, since the promise only rejects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to address Issue #8777 where the extension would get stuck loading indefinitely when the embedder service is unavailable.
Problem
When the CodeIndexManager cannot connect to the embedder service, the extension gets stuck loading and never fully activates until all folders in the VSCode workspace fail. This prevents users from using the extension UI even to fix configuration issues.
Solution
The fix involves two key changes:
Non-blocking initialization: Changed the CodeIndexManager initialization from blocking (await) to non-blocking (using .catch()) during extension activation. This allows the extension to fully activate even if the embedder service is unavailable.
Timeout for embedder validation: Added a 5-second timeout to the embedder validation process using Promise.race(). This prevents indefinite hanging when trying to connect to an unavailable service.
Changes Made
src/extension.tsto make CodeIndexManager initialization non-blockingsrc/services/code-index/service-factory.tsto add a 5-second timeout to embedder validationTesting
Related Issues
Fixes #8777
Feedback and guidance are welcome!
Important
Fixes extension hanging by making
CodeIndexManagerinitialization non-blocking and adding a timeout to embedder validation.CodeIndexManagerinitialization insrc/extension.tschanged to non-blocking using.catch()to prevent extension hanging.validateEmbedder()inservice-factory.tsusingPromise.race()to avoid indefinite hanging.src/extension.tsfor debugging when connection fails.This description was created by
for 0ac7f5a. You can customize this summary. It will automatically update as commits are pushed.